[virtualization] Use USB Redirection for KubeVirt VMs on ACP#793
Open
jing2uo wants to merge 1 commit into
Open
[virtualization] Use USB Redirection for KubeVirt VMs on ACP#793jing2uo wants to merge 1 commit into
jing2uo wants to merge 1 commit into
Conversation
Contributor
WalkthroughTwo new documentation files are added — one in English and one in Chinese — providing a complete how-to guide for KubeVirt USB Redirection (client passthrough via ChangesKubeVirt USB Redirection How-To Guide (EN + ZH)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/en/solutions/Use_USB_Redirection_for_KubeVirt_VMs_on_ACP.md (1)
56-56: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winClarify Windows client validation guidance.
Line 56 states "Validate the Windows client path separately before using it as a supported delivery workflow," but it is ambiguous what "validate the Windows client path" means. Does it mean:
- Verify that
usbredirectis inPATH?- Test the client setup in your Windows environment?
- Validate vendor/product ID access on Windows?
Consider rephrasing to be more explicit about what needs to be validated and how.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/en/solutions/Use_USB_Redirection_for_KubeVirt_VMs_on_ACP.md` at line 56, The phrase "Validate the Windows client path" on line 56 is ambiguous and unclear about what specifically needs to be validated. Replace this vague instruction with explicit guidance that clarifies the actual validation steps required for Windows clients. Specify what should be validated, such as ensuring usbredirect is available in PATH, verifying the UsbDk installation is correct, or testing the client setup in the Windows environment. Make the sentence more concrete and actionable by replacing the ambiguous phrase with specific validation requirements or testing procedures that readers should follow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/en/solutions/Use_USB_Redirection_for_KubeVirt_VMs_on_ACP.md`:
- Line 56: The phrase "Validate the Windows client path" on line 56 is ambiguous
and unclear about what specifically needs to be validated. Replace this vague
instruction with explicit guidance that clarifies the actual validation steps
required for Windows clients. Specify what should be validated, such as ensuring
usbredirect is available in PATH, verifying the UsbDk installation is correct,
or testing the client setup in the Windows environment. Make the sentence more
concrete and actionable by replacing the ambiguous phrase with specific
validation requirements or testing procedures that readers should follow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9f94c494-12e2-48f0-bb38-9eb64b25ed8b
📒 Files selected for processing (2)
docs/en/solutions/Use_USB_Redirection_for_KubeVirt_VMs_on_ACP.mddocs/zh/solutions/Use_USB_Redirection_for_KubeVirt_VMs_on_ACP.md
fanzy618
reviewed
Jun 25, 2026
|
|
||
| - ACP 虚拟化已安装并处于健康状态。 | ||
| - KubeVirt 版本包含 USB Redirection subresource。KubeVirt 从 v0.44 开始引入该能力；ACP 4.4 的 KubeVirt 构建包含 `clientPassthrough` API 字段。 | ||
| - 目标 VM/VMI 运行在支持 USB 的架构上。KubeVirt 会拒绝在 `s390x` 上使用 USB Redirection。 |
Contributor
There was a problem hiding this comment.
ACP 不支持 S390x， 所以可以不用提到这个
| 集群侧需要满足以下条件： | ||
|
|
||
| - ACP 虚拟化已安装并处于健康状态。 | ||
| - KubeVirt 版本包含 USB Redirection subresource。KubeVirt 从 v0.44 开始引入该能力；ACP 4.4 的 KubeVirt 构建包含 `clientPassthrough` API 字段。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --cached --checkbefore commit.virtualmachineinstances/usbredir.subresources.kubevirt.ioRBAC check syntax against the ACP KubeVirt workload API.Summary by CodeRabbit